Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM from OpenCL side! Thanks!



================
Comment at: test/SemaOpenCL/numbered-address-space.cl:9
+void 
test_numeric_as_to_generic_explicit_cast(__attribute__((address_space(3))) int 
*as3_ptr, float src) {
+  generic int* generic_ptr = (generic int*) as3_ptr; // Should maybe be valid?
+}
----------------
Ideally this is not governed by any specification. Generic compiler support for 
such `addrspacecast` is not possible but vendor can implement custom support. I 
think we can leave it as is until we have better idea how this should be 
supported.


https://reviews.llvm.org/D47154



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to