Hi Jeremy, Thank you for reporting the issue and apologies for inconvenience. There was another bug which caused buildbots crashes, I was looking into that before so I missed this one.
I built Clang 3.6 and Clang 3.7 locally, simply wrapping everything into std::move didn't resolve the issue, I reverted the changes ( https://reviews.llvm.org/rL338054) and will investigate. Thank you for reaching out, Kirill Bobyrev On Thu, Jul 26, 2018 at 7:16 PM Jeremy Morse <jeremy.morse.l...@gmail.com> wrote: > [Resending with cfe-commits@, whoops] > > Hi Kirill, > > We believe this patch might be breaking one of the buildbots: > > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/29719 > > Which is complaining about the std::unique_ptr copy constructor being > called in DexIndexTests.cpp. It seems likely that returning a unique_ptr: > > > std::unique_ptr<Iterator> > > createAnd(std::vector<std::unique_ptr<Iterator>> Children) { > > return llvm::make_unique<AndIterator>(move(Children)); > > } > > And sites such as: > > > auto AndEmpty = createAnd({create(L0)}); > > Are triggering a bug in clang 3.7 and 3.8 where the move constructor isn't > correctly inferred: > > https://godbolt.org/g/Aquug4 > > Wrapping everything in std::move will likely fix that, those two versions > of clang are still officially supported by LLVM/Clang. > > -- > Thanks, > Jeremy > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
