jkorous added a comment.

I like that idea! It looks like it's living in a wrong place anyway as it 
doesn't need access to any of implementation details (private members) of 
DiagnosticID. I would still like to preserve it as a function so this block of 
code has clear semantics and interface. 
How about I refactor it to a static free function in Warnings.cpp?


Repository:
  rC Clang

https://reviews.llvm.org/D49736



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to