aaron.ballman added a comment. A few small nits, but mostly looks good. Thank you for this!
================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:2404 @@ -2407,3 +2403,3 @@ static std::set<std::string> CustomSubjectSet; - std::set<std::string>::iterator I = CustomSubjectSet.find(FnName); + const auto I = CustomSubjectSet.find(FnName); if (I != CustomSubjectSet.end()) ---------------- I don't think this is the correct change (a const std::foo<bar>::iterator is often different than a std::foo<bar>::const_iterator). I would drop the const since the original is an iterator instead of a const_iterator anyway. ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:2518 @@ -2521,3 +2517,3 @@ static std::set<std::string> CustomLangOptsSet; - std::set<std::string>::iterator I = CustomLangOptsSet.find(FnName); + const auto I = CustomLangOptsSet.find(FnName); if (I != CustomLangOptsSet.end()) ---------------- Same here. ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:2581 @@ -2584,3 +2580,3 @@ static std::set<std::string> CustomTargetSet; - std::set<std::string>::iterator I = CustomTargetSet.find(FnName); + const auto I = CustomTargetSet.find(FnName); if (I != CustomTargetSet.end()) ---------------- And here. Repository: rL LLVM http://reviews.llvm.org/D15313 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
