jroelofs added inline comments.

================
Comment at: tools/scan-build-py/libscanbuild/driver.py:67
@@ +66,3 @@
+    except Exception:
+        logging.exception("Something unexpected had happened.")
+        return 127
----------------
dcoughlin wrote:
> rizsotto.mailinglist wrote:
> > jroelofs wrote:
> > > rizsotto.mailinglist wrote:
> > > > dcoughlin wrote:
> > > > > I think this error message can be improved. Perhaps "Unexpected error 
> > > > > running intercept-build"?
> > > > this line is printed as:
> > > > 
> > > >   intercept-build: ERROR: Something unexpected had happened.
> > > >   (and the stack-trace)
> > > > 
> > > > because the logging formating. so, 'intercept-build' and 'error' will 
> > > > be part of the message anyway.
> > > Is there a pythonic way of doing llvm crash handlers? I.e. the "here's 
> > > the steps to reproduce this, a stack trace, and a bug report url" things 
> > > that clang spits out.
> > this crash/exception is not a clang crash. it's more like this program's 
> > fault. clang crash reports are recorded already in crash report files (and 
> > linked into the html report file).
> Maybe this should ask the user to file a bug against scan-build? Can it point 
> to the bugzilla and tell the user what information, files, etc. they should 
> attach to the bug report to help us reproduce the problem? Just saying 
> "Something unexpected happened" is not as user-friendly as it could be 
> because it does not tell the user that the problem is not their fault nor 
> what they should do about it.
Oh, I don't mean to handle clang crashes... I mean for handling python crashes. 
I meant to draw an analogy to a feature that clang has: when it crashes, it 
prints a stack trace, and some steps to reproduce the problem.  I was wondering 
if a similar thing existed in python, for when a python app crashes.


http://reviews.llvm.org/D9600



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to