probinson marked an inline comment as done. probinson added a comment. In http://reviews.llvm.org/D14583#287406, @bcraig wrote:
> Looks good to me, but since this is in the LLVMSupport library, you should > probably add llvm-commits to the subscriber list. Ah, right, I should have. But I'm not seeing how to add subscribers post-facto. In http://reviews.llvm.org/D14583#287407, @aaron.ballman wrote: > LGTM with a nit. > > Also, I am really curious to know why CryptAcquireContext fails in those > cases! Me too. Once is a fluke, twice is a trend. Probably some obscure system-resource problem but it would be nice to be sure. ================ Comment at: lib/Support/Windows/Process.inc:421 @@ +420,3 @@ +// Include GetLastError() in a fatal error message. +static void ReportLastErrorFatal(const char *msg) { + std::string ErrMsg; ---------------- aaron.ballman wrote: > msg should be Msg for style conventions. The prevailing style in this file is for lowercase parameter names, but I guess we gotta start somewhere! http://reviews.llvm.org/D14583 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
