aaron.ballman added a comment.

In http://reviews.llvm.org/D12547#287153, @ahatanak wrote:

> Marking virtual functions as disable_tail_calls is fine since 
> disable_tail_calls affects the call sites inside the body of the marked 
> function. In your example, it prevents tail call optimization on call sites 
> inside B::g, but doesn't affect call sites in D::g.


Okay, that's reasonable, but you should definitely update the documentation to 
reflect that and have at least one codegen test that ensures the behavior is 
implemented as-expected.


http://reviews.llvm.org/D12547



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to