Hello,

sorry for the late reply, I did not note this email …


> Sure. :)  Review is based off the attachment I grabbed from here: 
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html

That’s correct.

> A few nits:
> - test/Sema/enable_if.cpp line 24: Please use __attribute__(( instead of 
> __attribute((
> - Can we have a similar test for a function that returns an Incomplete? 

Sure. Also in that case, only the error about Incomplete is reported. Please 
check the attached patch.

Attachment: enable_if.diff
Description: Binary data


Thank you very much,
Ettore Speziale
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to