zaks.anna added a comment.

> > It's more user friendly to report this issue at the last point where the 
> > request is available rather than the last line of the function.
> 

> >  This looks similar to leak report checking. Is it?

> 

> 

> Yes, that's not very common but possible.

>  Does this change involve the use of a BugReporterVisitor?!


You should register/report the diagnostic at check::DeadSymbols event instead 
of check:: EndFunction; that way the error will be reported earlier.

> You're right, it's very similar.





http://reviews.llvm.org/D12761



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to