aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with one minor nit. ================ Comment at: lib/Sema/Sema.cpp:729 @@ +728,3 @@ + Diag(WeakID.second.getLocation(), diag::warn_attribute_wrong_decl_type) + << "weak" << ExpectedVariableOrFunction; + else ---------------- Should be "'weak'" instead of "weak" so that the diagnostic is properly quoted for the user. http://reviews.llvm.org/D12904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
