angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Add the test about replacements in several arguments of the same macro call,
now that the problem has been fixed.
http://reviews.llvm.org/D12933
Files:
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/modernize-loop-convert-extra.cpp
===================================================================
--- test/clang-tidy/modernize-loop-convert-extra.cpp
+++ test/clang-tidy/modernize-loop-convert-extra.cpp
@@ -702,21 +702,15 @@
printf("Value: %d\n", CONT arr[i]);
}
- // FIXME: Right now, clang-tidy does not allow to make insertions in several
- // arguments of the same macro call. The following code:
- // \code
- // for (int i = 0; i < N; ++i) {
- // TWO_PARAM(arr[i], arr[i]);
- // THREE_PARAM(arr[i], arr[i], arr[i]);
- // }
- // \endcode
- // Should be converted to this:
- // \code
- // for (auto & elem : arr) {
- // TWO_PARAM(elem, elem);
- // THREE_PARAM(elem, elem, elem);
- // }
- // \endcode
+ // Multiple arguments.
+ for (int i = 0; i < N; ++i) {
+ TWO_PARAM(arr[i], arr[i]);
+ THREE_PARAM(arr[i], arr[i], arr[i]);
+ }
+ // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop instead
+ // CHECK-FIXES: for (auto & elem : arr)
+ // CHECK-FIXES-NEXT: TWO_PARAM(elem, elem);
+ // CHECK-FIXES-NEXT: THREE_PARAM(elem, elem, elem);
}
} // namespace Macros
Index: test/clang-tidy/modernize-loop-convert-extra.cpp
===================================================================
--- test/clang-tidy/modernize-loop-convert-extra.cpp
+++ test/clang-tidy/modernize-loop-convert-extra.cpp
@@ -702,21 +702,15 @@
printf("Value: %d\n", CONT arr[i]);
}
- // FIXME: Right now, clang-tidy does not allow to make insertions in several
- // arguments of the same macro call. The following code:
- // \code
- // for (int i = 0; i < N; ++i) {
- // TWO_PARAM(arr[i], arr[i]);
- // THREE_PARAM(arr[i], arr[i], arr[i]);
- // }
- // \endcode
- // Should be converted to this:
- // \code
- // for (auto & elem : arr) {
- // TWO_PARAM(elem, elem);
- // THREE_PARAM(elem, elem, elem);
- // }
- // \endcode
+ // Multiple arguments.
+ for (int i = 0; i < N; ++i) {
+ TWO_PARAM(arr[i], arr[i]);
+ THREE_PARAM(arr[i], arr[i], arr[i]);
+ }
+ // CHECK-MESSAGES: :[[@LINE-4]]:3: warning: use range-based for loop instead
+ // CHECK-FIXES: for (auto & elem : arr)
+ // CHECK-FIXES-NEXT: TWO_PARAM(elem, elem);
+ // CHECK-FIXES-NEXT: THREE_PARAM(elem, elem, elem);
}
} // namespace Macros
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
