On Mon, Aug 24, 2015 at 5:44 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> LGTM with a caveat. > > Changing diagnostic messages is scary because it can inadvertently break > tools and IDE's. So there is a chance someone might want this reverted in > the future. But for now it seems helpful :). > To the best of my knowledge, we have no policy which forbids us from adding/removing/changing diagnostics. Was this discussed at some point in the past? > > vedant > > On Aug 24, 2015, at 1:19 PM, Nick Lewycky via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On 19 August 2015 at 15:18, Nick Lewycky <nlewy...@google.com> wrote: > > On 10 August 2015 at 19:08, Nick Lewycky <nlewy...@google.com> wrote: > > This simple-minded patch extends the case where we report "no viable > conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable > conversion from returned value of type 'X' to function return type 'Y'" > when used in that context. > > > > In lieu of adding tests for this diagnostic explicitly, I've only > updated the tests where the patch changes their result. > > > > Please review! > > > > Ping! > > > > Ping! > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=nRkKAYlatRp-Wgk-tAtmRg&m=zsNXNManBK37vPs3xRquJLuWu0PUZNNKbjXmDbYrT18&s=36cwmt-VUhgwwq4FvAY4AnJXluk0LRYerkogSqFNuqM&e= > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
