filcab added a comment. It seems you missed some `\brief`. Other than that, no complaints on this side.
================ Comment at: lib/CodeGen/CGExpr.cpp:2303 @@ -2302,4 +2302,3 @@ - if (TrapCond) - EmitTrapCheck(TrapCond); + if (TrapCond) EmitSanitizeTrapCheck(TrapCond); if (!FatalCond && !RecoverableCond) ---------------- Did clang-format do this? ================ Comment at: lib/CodeGen/CodeGenFunction.h:2900 @@ +2899,3 @@ + private: + /// \brief Create a basic block that will call the specified trap function, + /// and emit a conditional branch to it. ---------------- There's still a `\brief` here. ================ Comment at: lib/CodeGen/CodeGenFunction.h:2904 @@ +2903,3 @@ + + /// \brief Emit a call to trap or debugtrap and attach function attribute + /// "trap-func-name" if nonempty. ---------------- I still see `\brief`. http://reviews.llvm.org/D12181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
