zaks.anna requested changes to this revision. zaks.anna added a comment. This revision now requires changes to proceed.
This patch needs tests. We should treat the improvements to HTML uniquing separately from this patch. > But I think it's not a critical issue as of now and it can be considered at > the next step. I think it is very relevant to the design of the solution. For example, you could keep the information about the reports in the plist files and use those to render the reports in HTML. > As I mentioned, I think the simplist way of comparing HTML reports is to have > the BugID in each HTML report so that we can just compare HTML reports > >whether the file exists or not. I believe scan-build creates and names those files. How do you propose to pass this information from the clang invocation to scan-build? Can you check if the BugID is already part of the HTML report itself? That might be a much simpler solution. (One thing to keep in mind is that right now you get more reports with plist output. Because HTML cannot currently display cross file paths, this reports are not reported.) http://reviews.llvm.org/D10305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
