On 7/30/15 12:47 PM, Alexey Samsonov wrote:
I actually support the idea of including LLVM CMake modules from libc++ CMake: the logic for building instrumented LLVM and building instrumented libc++ should better be listed in a single place, and be controlled by LLVM_USE_SANITIZER options: i.e. when we configure libc++ from compiler-rt, we should pass -DLLVM_USE_SANITIZER=Thread rather than -DCMAKE_CXX_FLAGS=-fsanitize=thread. It's not possible to do this right now, though (for instance we build two different versions of MSan-libc++), but I think I'd be able to work on that once your patch lands and the dust settles.
What would/does `-DLLVM_USE_SANITIZER=Thread` do differently than `-DCMAKE_CXX_FLAGS=-fsanitize=thread` here?
Jon -- Jon Roelofs [email protected] CodeSourcery / Mentor Embedded -- Jon Roelofs [email protected] CodeSourcery / Mentor Embedded _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
