Re: [PATCH] ignore __declspec(novtable) on non-Windows platforms

Mon, 20 Jul 2015 12:03:30 -0700


On Jul 17, 2015, at 5:00 PM, Richard Smith <[email protected]> wrote:

On Fri, Jul 17, 2015 at 3:43 PM, David Majnemer <[email protected]> wrote:


On Fri, Jul 17, 2015 at 3:13 PM, Richard Smith <[email protected]> wrote:
It seems to me that we should be basing the check on the TargetCXXABI rather than whether the target is Windows.

That's why I suggested to use llvm::Triple::isKnownWindowsMSVCEnvironment, it's what we use to set the CXX ABI: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/TargetInfo.cpp?revision=242198&view=markup#l87

That's only the default; targets are permitted to override it, and many of them do so. ItaniumWindowsARMleTargetInfo sets a non-MS C++ ABI, for instance.

Here’s a new patch that checks TargetCXXABI.

Attachment: novtable.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to