logan added inline comments.
================
Comment at: include/unwind.h:217
@@ -216,1 +216,3 @@
+#if !defined(__LIBUNWIND_DONT_INLINE_UNWIND_LEVEL1)
+#define __LIBUNWIND_EXPORT_UNWIND_LEVEL1 static __inline__
----------------
compnerd wrote:
> The double negative hurts. Would you be opposed to switching this around so
> that we can have:
>
> __LIBUWNIND_INLINE_LEVEL1
How about changing this to:
#if defined(__LIBUNWIND_UNWIND_LEVEL1_EXTERNAL_LINKAGE
#define __LIBUNWIND_EXPORT_UNWIND_LEVEL1 extern
#else
#define __LIBUNWIND_EXPORT_UNWIND_LEVEL1 static __inline__
#endif
My intuition is to make sure that these functions are inlined by default, i.e.
other files can get the inlined version without any extra `#define`s.
http://reviews.llvm.org/D11191
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
