r242150 2015-07-14 17:56 GMT+03:00 İsmail Dönmez <[email protected]>:
> Works fine out of the box, cheers! > > On Tue, Jul 14, 2015 at 3:49 PM, Yaron Keren <[email protected]> > wrote: > > Here is updated diff with all comments addressed. > > ismail: could you check this one last time on openSUSE before I commit? > > > > > > 2015-07-14 14:33 GMT+03:00 Joerg Sonnenberger <[email protected]>: > >> > >> On Mon, Jul 13, 2015 at 11:53:47PM +0300, Yaron Keren wrote: > >> > Re-reading, the problem is with using #ifdef inside the conditional or > >> > using the #ifdef at all? > >> > >> the problem is adding #else blocks that themselve that with else. > >> Can you restructure the branches to avoid that? A single trailing > >> conditional block is fine as is a single leading conditional block. > >> But having #if #else #endif where both start with a else is bad. > >> > >> Joerg > >> _______________________________________________ > >> cfe-commits mailing list > >> [email protected] > >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
