================
Comment at: include/clang/Format/Format.h:159
@@ -158,1 +158,3 @@
+ /// \brief A regular expression matching macros that start a block.
+ std::string BlockBeginMacros;
----------------
djasper wrote:
> I think this should be consistent with 'ForEachMacros' and whatever other
> macro kinds we are going to introduce (see Manuel's comment). Specifically,
> all of them should either be a regular expression or a list of strings. I am
> fine with turning them into regular expressions.
>
> I wonder whether all of these would be more discoverable if we chose the name
> so that they are consecutive, e.g. MacrosBlockBegin, MacrosBlockEnd,
> MacrosForEach. But I am not sure. Any thoughts?
I went with MacroBlock{Begin,End} because the plural at the beginning sounds
weird. I'll add a regex-based MacroForEach in a future patch.
================
Comment at: lib/Format/Format.cpp:477
@@ -473,3 +476,3 @@
FormatStyle getMozillaStyle() {
FormatStyle MozillaStyle = getLLVMStyle();
----------------
djasper wrote:
> Do you have good defaults here?
Yes, but I think we (Mozilla) would prefer to keep them in our .clang-format
file because the set of macros is likely to change.
http://reviews.llvm.org/D10840
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
