On Thu, Jun 25, 2015 at 1:23 PM Meador Inge <[email protected]> wrote:
> This fix LGTM, but I do wonder about one thing. The following pattern > seems to occur all over `Sema`: > > InstantiatingTemplate Inst(*this, PointOfInstantiation, Decl); > if (Inst.isInvalid()) > ... > > For example, in `Sema::InstantiateEnum`. Why aren't we marking decls > invalid in those other places? > That is exactly what Richard gets at with the solution being to swap the check up a bit instead. > > > http://reviews.llvm.org/D10622 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
