On Thu, Jun 25, 2015 at 8:20 AM, Andrey Bokhanko <[email protected]> wrote: > On Wed, Jun 24, 2015 at 7:07 PM, Aaron Ballman <[email protected]> > wrote: >> This is not testing what I was hoping to test. I wanted to know if a >> declaration of foo() in an extern "C" language linkage block is >> handled correctly. Instead, try: >> >> extern "C" { >> int foo() { return 1; } >> } >> >> And then (I presume), CHECK: define i32 @bar() >> >> Other changes look good though. > > Ouch! This just a silly mistake on my part... I moved the test to > redefine_extname.cpp (which is correct), but forgot to add extern "C". > > This is fixed now -- and I'm very sorry for making you unnecessarily > re-review this tiny patch once again. BTW, thank you for investing > your time for reviewing -- much appreciated!
No worries, that's why we have the review process in the first place! :-) Patch LGTM! Thank you for working on this! ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
