Just to be clear, this commit seems good to me, and I'm fine with it being in, but please don't submit patches without review once you've asked for it.
On Tue, Jun 16, 2015 at 2:22 PM Chandler Carruth <[email protected]> wrote: > Doug, why did you commit this without review? That's not really cool after > you've asked folks to code review it and without any update. > > On Tue, Jun 16, 2015 at 12:43 PM Douglas Katzman <[email protected]> wrote: > >> REPOSITORY >> rL LLVM >> >> http://reviews.llvm.org/D10444 >> >> Files: >> cfe/trunk/lib/Driver/ToolChains.cpp >> >> Index: cfe/trunk/lib/Driver/ToolChains.cpp >> =================================================================== >> --- cfe/trunk/lib/Driver/ToolChains.cpp >> +++ cfe/trunk/lib/Driver/ToolChains.cpp >> @@ -42,10 +42,6 @@ >> MachO::MachO(const Driver &D, const llvm::Triple &Triple, >> const ArgList &Args) >> : ToolChain(D, Triple, Args) { >> - getProgramPaths().push_back(getDriver().getInstalledDir()); >> - if (getDriver().getInstalledDir() != getDriver().Dir) >> - getProgramPaths().push_back(getDriver().Dir); >> - >> // We expect 'as', 'ld', etc. to be adjacent to our install dir. >> getProgramPaths().push_back(getDriver().getInstalledDir()); >> if (getDriver().getInstalledDir() != getDriver().Dir) >> >> EMAIL PREFERENCES >> http://reviews.llvm.org/settings/panel/emailpreferences/ >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
