> Regarding the options validation on the frontend: > Indeed, it would be nicer to use a clang method to check if a string is an > identifier however I did not found a >nice way to do that. The only way I > came up with was to create a raw lexer and lex the option string. If you > >consider that better than using a RegEx I will alter the patch accordingly.
It would also be good to check that the names of the checkers and packages are identifiers and that the option is a fully qualified checker name followed by the option name... Let's create a separate patch for validation and check if it can be done more elegantly. The rest of the patch LGTM and can land. Thank you for working on this! http://reviews.llvm.org/D7905 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
