mphilippov added a comment.
In D25423#589481 <https://phabricator.kde.org/D25423#589481>, @pvuorela wrote: > > Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what? > > The main question was how should the three attributes play together. But another question: why isn't setBackgroundColor enough for the background color? Ok. 1. There is a bug in calligra with alpla-channel. So with style->setBackgroundColor(QColor()); all transparent cells will be painted with black color. 2. This part of code isn't handled in all spreadsheet formats either ods or xls or xlsx. Setting brush needs us to paint all the cell with the required color REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25423 To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste Cc: dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoever
