aacid added a comment.
In D16406#349051 <https://phabricator.kde.org/D16406#349051>, @arojas wrote: > In D16406#349046 <https://phabricator.kde.org/D16406#349046>, @aacid wrote: > > > When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 <https://phabricator.kde.org/D16406> (i.e. this very same patch) or the compilation error because of the overrides? > > > I mean this one, the other error doesn't happen in 3.1 since you only pushed the changes to master Sure, as i said the fact that the error doesn't happen "means nothing", the code isn't working with a newer poppler because the functions signature is wrong (aka old) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16406 To: arojas, #calligra:_3.0, aacid, pino Cc: rjvbb, pino, Calligra-Devel-list, dcaliste, cochise, vandenoever
