if its via phab, best use arc land, which will do the 'right thing' and automatically merge to master and close the review
On Wed, 24 Jan 2018 at 09:04 Dag <dand...@get2net.dk> wrote: > Sebastian Pettke skrev den 2018-01-23 23:38: > >> On January 23, 2018 at 10:30 AM Dag <dand...@get2net.dk> wrote: > >> > >> Sebastian Pettke skrev den 2018-01-22 21:00: > >> > Hi, > >> > > >> > I tried to submit a patch using Phabricator: > >> > https://phabricator.kde.org/D10014 > >> > > >> > but it won't appear on this page: > >> > https://phabricator.kde.org/project/profile/23/ > >> > > >> > Is this expected behaviour or is there anything I am missing or should > >> > do now? > >> I'm not overly comfortable with phab myself, the interface might be > >> intuitive but it does not match my intuition ;) > >> But, we got the review request, looking at it right now. > > > > Thanks for reviewing. > > It does not seem to be in the repository yet, what would be the next > > steps to get it there? > git push, or if you used arc: arc land > > >
