----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125493/#review86367 -----------------------------------------------------------
Ship it! Sorry, was waiting for Zagge. Please push, I'll forward to master. There might actually be exactly the same issue in the VectorShape and in the VideoShape... - Boudewijn Rempt On Oct. 5, 2015, 10:22 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125493/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 10:22 a.m.) > > > Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann. > > > Repository: calligra > > > Description > ------- > > Mistyping a filename in the file widget would lead to the job failing silently > and the rest of the code trying to load an empty bytearray as the image data. > > Better show a msgbox on error and delete the shape. > > But this is last resort (e.g. remote URL and lost internet during transfer), > see next commit. > > > Diffs > ----- > > plugins/pictureshape/PictureShapeConfigWidget.h > 14b59aaf749b335a3f69b075a8422732664f0ecb > plugins/pictureshape/PictureShapeConfigWidget.cpp > e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0 > > Diff: https://git.reviewboard.kde.org/r/125493/diff/ > > > Testing > ------- > > > Thanks, > > David Faure > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
