> On June 2, 2015, 7:50 p.m., Tomas Mecir wrote: > > After testing, yeah, the plugin stuff doesn't work, please either port that > > as well to the new API, or keep it commented out for now. Otherwise looks > > good. > > > > Thanks!
Yes, problem with KPluginSelector and new Calligra plugins being incompatible tracked at https://phabricator.kde.org/T448. The port of the buttons to Qt5 as done in this patch has been solved meanwhile by other commits. So this review request might need to be discarded now. Peter, can you please do that? Thanks for your effort. Hopefully your next patch will then make it into the repo :) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123985/#review81091 ----------------------------------------------------------- On June 2, 2015, 4:08 p.m., Peter Simonsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123985/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 4:08 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Fix buttons and signals. > ?eenable the plugin selector. > > > Diffs > ----- > > CMakeLists.txt a4e3f24 > sheets/CMakeLists.txt c7567c4 > sheets/part/dialogs/PreferenceDialog.h 543bf45 > sheets/part/dialogs/PreferenceDialog.cpp 8b044a8 > > Diff: https://git.reviewboard.kde.org/r/123985/diff/ > > > Testing > ------- > > > Thanks, > > Peter Simonsson > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
