----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123942/#review80968 -----------------------------------------------------------
Ship it! Ship It! - Adam Pigg On May 30, 2015, 9:41 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123942/ > ----------------------------------------------------------- > > (Updated May 30, 2015, 9:41 a.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich > W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech > Kosowicz. > > > Bugs: 330410 > http://bugs.kde.org/show_bug.cgi?id=330410 > > > Repository: calligra > > > Description > ------- > > Keep pointer to related Connection object in query, so it can be used to find > related tables > > To do this, add a QuerySchema ctor and allow to call it internally by the > parser. > We had to move QuerySchemaPrivate to separate files. > > > Diffs > ----- > > libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 > libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 > libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 > libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be > libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 > libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 > libs/db/queryschema_p.h PRE-CREATION > libs/db/queryschema_p.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123942/diff/ > > > Testing > ------- > > Queries work as expected, changes only relate to the conn pointer > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
