> On May 15, 2015, 11:17 p.m., Jarosław Staniek wrote: > > Let's integrate it into the example-piggz branch for KReport. > > Please note that we did not enable the map plugin in KReport. Do you want > > to take this task?
i decided on one more round of review due to major fixes :) - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123498/#review80447 ----------------------------------------------------------- On May 17, 2015, 3:45 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123498/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 3:45 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > Tidied up and removed unused function > Enabled the scripting interface > Implemented the new maniupulateData interface to allow > controlling the map widget from a report script > > Requires review 123496 > > > Diffs > ----- > > libs/koreport/common/KoReportASyncItemBase.h > 6f7e4db743f83bf7502b1637fec281b52d93cab5 > libs/koreport/common/KoReportASyncItemBase.cpp > 2949ef80ea5e939a33ff8048a2f55dec00fd2ffd > libs/koreport/renderer/KoReportPreRenderer.cpp > 16066c530d30684460aa7dfb7801a76b25517d8f > libs/koreport/renderer/scripting/krscriptreport.h > 326fe63507ee89ec7bd2fae0ddaf6fdaa17cab53 > libs/koreport/renderer/scripting/krscriptreport.cpp > 8fe551cad807931775ba67e1647dc832f310850c > plugins/reporting/maps/KoReportItemMaps.h > eb8404b8720c084e7cc174c84906c4aadecae396 > plugins/reporting/maps/KoReportItemMaps.cpp > 3aa8942d8041a224fbd8623fd97388fdd2a33584 > plugins/reporting/maps/KoReportMapsPlugin.cpp > 675fd96b6b6c335b946f90611904f1bb20b79a2f > plugins/reporting/maps/krscriptmaps.h > 38fba1eade5f025afcf1fc8b586f646f03238456 > plugins/reporting/maps/krscriptmaps.cpp > 9fc21c7fcb94b888d8bd930fe770af787c6f759b > > Diff: https://git.reviewboard.kde.org/r/123498/diff/ > > > Testing > ------- > > Added map to report > Created script to control map data from individual fields > Report renders correctly > > > File Attachments > ---------------- > > POI Database > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/0012b23c-6396-46e3-8d5c-4d6080338aae__POI.kexi > What the report should look like > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/25/02fe1f44-6159-46b4-9998-a401c885bc3a__rptPoi.pdf > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
