----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123511/ -----------------------------------------------------------
Review request for Calligra. Repository: calligra Description ------- While investigating the KoLZF compress/decompress methods and what data actually is processed there, I also had to grasp what KoXmlVector is doing. To help myself I wrote some unit tests for it (for which I needed to move the class into an own file). Given they exist now, proposing to add those unit tests to the Calligra repo, including a little bit more documentation, so they might help protecting against any future regressions (e.g. during the Qt5/KF5 port) :) Diffs ----- libs/odf/KoXmlReader.cpp 75b1114 libs/odf/KoXmlVector.h PRE-CREATION libs/odf/tests/CMakeLists.txt 689bfe4 libs/odf/tests/TestKoXmlVector.h PRE-CREATION libs/odf/tests/TestKoXmlVector.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123511/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
