----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123471/#review79407 -----------------------------------------------------------
kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp (line 36) <https://git.reviewboard.kde.org/r/123471/#comment54238> Please add a comment here what the 1200 means plugins/reporting/maps/KoReportItemMaps.cpp (line 96) <https://git.reviewboard.kde.org/r/123471/#comment54239> coding style for () And please alway use { } for 'if' + In the commit log please list what has been improved exactly. We need this not only for the changelog! - Jarosław Staniek On April 23, 2015, 1:19 a.m., Radosław Wicik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123471/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 1:19 a.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam > Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Repository: calligra > > > Description > ------- > > Kexi: MapBrowser: Improved properties for forms and reports > > > Diffs > ----- > > kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.h d8f9da5 > kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp c86462e > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.h ffaea65 > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp df9ad7e > libs/koproperty/editors/spinbox.cpp 1763861 > plugins/reporting/maps/KoReportItemMaps.cpp c862655 > > Diff: https://git.reviewboard.kde.org/r/123471/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Radosław Wicik > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
