----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123392/#review79154 -----------------------------------------------------------
Ship it! Thanks! For sketch/gemini this change is fine, too, because it should share the resources with krita. - Boudewijn Rempt On April 16, 2015, 11:11 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123392/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 11:11 p.m.) > > > Review request for Calligra, Tomas Mecir and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > "appdata" gets resolved to "share/appname" with KStandardDirs. And `appname` > will be the name of the KApplication app, whatever that is. So with plugins > one better uses "data" and explicitely writes the prefix of the respective > program (or plugin) whose data/resources should be accessed. > > See "A type that is added by the class KApplication" etc. in > http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html > > This patch changes most usages of "appdata" to "data". From a quick test > Krita and Sheets still seem to work for what got changed (Krita Sketch and > Krita Gemini not yet tested for what is possible). > > Those usages with `KoScript*` classes I did not touch (yet), as there > potentially things should be resolved relative to the real app (not > investigated further so far, so no clue). > > > Diffs > ----- > > krita/crashreporter/mainwindow.cpp eff5516 > krita/plugins/extensions/resourcemanager/resourcebundle.cpp e5aacad > krita/ui/input/config/kis_input_configuration_page.cpp a1d34c9 > krita/ui/input/kis_input_profile_manager.cpp 84222d2 > sheets/ui/CellToolBase.cpp 4d5db5e > > Diff: https://git.reviewboard.kde.org/r/123392/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
