> On Feb. 28, 2015, 1:42 p.m., Camilla Boemann wrote: > > shouldn't this feature be in all of of calligra ? > > that said we are closed for features until 3.0 is released > > Friedrich W. H. Kossebau wrote: > Would agree this should be a feature calligra wide. > > WRT featue freeze, if it is nice feature, small code change, and well > reviewed, I would be for still letting that in. No rules without reasonable > exceptions. > > Not yet looked at the code in detail, though. > > Boudewijn Rempt wrote: > Maybe, maybe not. Calligra apps that use the sidebar instead of dockers > probably don't need it. In any case, Krita no longer shares the komain and > the mainwindow code with the rest of calligra, so if the rest of calligra > wants this feature, it can be implemented -- but there's no need for Moritz > to do that. > > Friedrich W. H. Kossebau wrote: > No need, but would be great :) (Besides, the sidebar is not integrating > all the dockers, there are still quite some normal ones also in those apps. > And even hiding the titlebar of the sidebar would be nice to have). > So Moritz, do you think you could give it a try to also do this patch for > the KoMainWindow-based code?
If that scratches an itch, why not, but let this be clear: there is absolutely no obligation whatsoever. - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122753/#review76765 ----------------------------------------------------------- On Feb. 28, 2015, 1:01 p.m., Moritz Molch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122753/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 1:01 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Inspired by kdenlive, this small patch adds the option to show/hide the > titlebars of all dockers to the settings menu. > > > Diffs > ----- > > krita/ui/KisMainWindow.cpp e8c6009 > krita/ui/kis_config.h b6852de > krita/ui/kis_config.cc a09c7b8 > libs/widgets/KoDockWidgetTitleBar.cpp cf0c722 > krita/krita.action b683185 > krita/krita.rc 0ec0931 > krita/ui/KisMainWindow.h 9cdcce5 > > Diff: https://git.reviewboard.kde.org/r/122753/diff/ > > > Testing > ------- > > Tested on Ubuntu 14.04 > > > Thanks, > > Moritz Molch > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
