----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122535/#review76467 -----------------------------------------------------------
Good! After rewriting history (src/ dir now exist, tests/ are now in examples/, etc.) I integrated your patch into the scratch repo (master) ssh://g...@git.kde.org/scratch/staniek/kproperty. Copy of the line style code makes sense, it's universal. KoUnit - does not, it's office suite-specific. So I disabled KoUnit. I also removed koproperty_export.h; kproperty_export.h should be generated by cmake. Please fix the order of args in QObject::tr(const char * sourceText, const char * disambiguation) as we noticed. Please fix the build as I obviously broken it while rewriting the history ;) - Jarosław Staniek On Feb. 11, 2015, 11:10 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122535/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 11:10 p.m.) > > > Review request for Calligra, Friedrich W. H. Kossebau, Jarosław Staniek, and > Wojciech Kapuscinski. > > > Repository: calligra > > > Description > ------- > > Port of koproerty to qt5 for comment. Currently buggy and incomplete, up for > review for comments! > > Copied some files from calligra to allow building. > > > Diffs > ----- > > editors/pixmapedit.cpp a11ae93 > editors/pointedit.h 02abeac > editors/pointedit.cpp e471263 > editors/pointfedit.h e2992fa > editors/pointfedit.cpp e4e75e6 > editors/rectedit.h a635871 > editors/rectedit.cpp 105cd9e > editors/sizeedit.h 9886650 > editors/sizeedit.cpp 08af042 > editors/sizefedit.h ca0806d > editors/sizefedit.cpp 825ae56 > editors/sizepolicyedit.h 7b563ca > editors/sizepolicyedit.cpp fa23e58 > editors/spinbox.h 55afb92 > editors/spinbox.cpp 1763861 > editors/stringedit.h 5159f8b > editors/stringedit.cpp 49f3cdf > editors/stringlistedit.h faafae8 > editors/symbolcombo.h 8a9360a > editors/symbolcombo.cpp 1c67ddc > editors/timeedit.h 0b853a3 > editors/timeedit.cpp aa3665e > editors/urledit.h 82d072d > editors/utils.h 883c452 > editors/utils.cpp 7ec6938 > koproperty_export.h e4664b7 > tests/CMakeLists.txt 1c02bfe > tests/main.cpp 45a7c55 > tests/test.cpp 2be3bb5 > editors/cursoredit.cpp 4bd0c6b > editors/dateedit.h 5adc02e > editors/dateedit.cpp d3d87f2 > editors/datetimeedit.h d50d81e > editors/datetimeedit.cpp e5f7b13 > editors/dummywidget.h 35b8ade > editors/fontedit.h 642ca02 > editors/fontedit.cpp cf441d2 > editors/linestyleedit.h 43ca61c > editors/linestyleedit.cpp 64c0e92 > editors/pixmapedit.h 0d71800 > CMakeLists.txt 87f206d > DefaultFactory.cpp 61f7e2a > EditorDataModel.cpp 8272888 > EditorView.h 6bce43b > EditorView.cpp 94c8087 > Factory.h babb1b9 > Factory.cpp 53b4210 > KoLineStyleItemDelegate.cpp PRE-CREATION > KoLineStyleItemDelegate_p.h PRE-CREATION > KoLineStyleModel.cpp PRE-CREATION > KoLineStyleModel_p.h PRE-CREATION > KoLineStyleSelector.h PRE-CREATION > KoLineStyleSelector.cpp PRE-CREATION > KoUnit.h PRE-CREATION > KoUnit.cpp PRE-CREATION > Property.h e4b3bd0 > Property.cpp 37d2b7d > Set.h b3c4c2a > Set.cpp 4a0f787 > Utils.cpp 0ee8c99 > editors/booledit.h 8f1cb6d > editors/booledit.cpp 207140f > editors/coloredit.h 1c35ec9 > editors/coloredit.cpp 1d03a9f > editors/combobox.h 225c70b > editors/combobox.cpp 4270326 > > Diff: https://git.reviewboard.kde.org/r/122535/diff/ > > > Testing > ------- > > Ran tests/propertytet to see what happens > Gui loads and shows properties, some work and some dont! > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
