> On Feb. 21, 2015, 9:44 p.m., Adam Pigg wrote: > > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp, line 402 > > <https://git.reviewboard.kde.org/r/122656/diff/1/?file=350477#file350477line402> > > > > Use an enum maybe?
It's on/off only. > On Feb. 21, 2015, 9:44 p.m., Adam Pigg wrote: > > kexi/widget/tableview/KexiTableScrollArea.cpp, line 1673 > > <https://git.reviewboard.kde.org/r/122656/diff/1/?file=350479#file350479line1673> > > > > Why this here? I'd like to keep it there. As you know debugging focus/activation events is hard; this is one way to debug it -- by name. > On Feb. 21, 2015, 9:44 p.m., Adam Pigg wrote: > > kexi/widget/tableview/KexiTableScrollArea.cpp, line 1687 > > <https://git.reviewboard.kde.org/r/122656/diff/1/?file=350479#file350479line1687> > > > > Why this here? like above - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122656/#review76408 ----------------------------------------------------------- On Feb. 21, 2015, 12:47 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122656/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 12:47 a.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. > Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Improve Kexi table view in combo box popups and spreadsheet mode > > This mostly fixes table designer. Query designer needs some more work. > > > Diffs > ----- > > kexi/widget/tableview/KexiTableScrollArea.h > 4c61c39352b947b6e655653804665de1d827f701 > kexi/widget/tableview/KexiTableScrollArea.cpp > 0c9ff503bc859fe6290431692a3e277d618b61a4 > kexi/widget/tableview/KexiTableScrollArea_p.h > ce1fb4a35d434565987de14f9a98eaf70a24c6ae > kexi/widget/tableview/KexiTableScrollArea_p.cpp > 1814a82a6f9fb79513c71a9d86a3dbe0ff11e825 > kexi/widget/tableview/kexicomboboxpopup.cpp > c57918602418761279590878b664c665b5af3ec0 > kexi/widget/tableview/kexicomboboxtableedit.cpp > bd28547190303f4e6fdd73638e1bdb3baa880a50 > kexi/plugins/tables/kexitabledesignerview.cpp > c09b7ec76657abc3f8be0edbfd0717c89cbcf2e2 > kexi/widget/dataviewcommon/kexidataawareobjectiface.h > b73ae64a6f2eef7e96989b749e6535e9e5efdcc6 > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp > 05c5b5549b889f827a604baddf29d4753d7addd3 > kexi/formeditor/connectiondialog.cpp > 28b5fb61804b38680120d771ce5819c5a7a274c5 > kexi/plugins/queries/kexiquerydesignerguieditor.cpp > c482a149a61f19e2d37e7e48a489fbe0c8096dea > > Diff: https://git.reviewboard.kde.org/r/122656/diff/ > > > Testing > ------- > > Table designer tested, including adding/removing rows and showing combo boxes > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
