> On Jan. 20, 2015, 10:09 p.m., Friedrich W. H. Kossebau wrote: > > cmake/modules/FindOpenJPEG.cmake, line 32 > > <https://git.reviewboard.kde.org/r/122114/diff/5/?file=343906#file343906line32> > > > > Is this really needed? Does it not work without? > > > > From how I understood the docs, "<prefix>/lib for each <prefix> in > > CMAKE_SYSTEM_PREFIX_PATH" will be tried, so no need to list this suffix > > here again explicitely. > > If it does not work, please add a comment to this line why it is needed.
It looks a bit strange to have a `PATH_SUFFIXES` line without any suffixes following it, but it seems to work. > On Jan. 20, 2015, 10:09 p.m., Friedrich W. H. Kossebau wrote: > > cmake/modules/FindVc.cmake, line 33 > > <https://git.reviewboard.kde.org/r/122114/diff/5/?file=343908#file343908line33> > > > > This suffix seems strange to me, but then I have no clue. Did you try > > if it works without? > > And if needed, please add a comment where it is needed for, so it could > > be revisited later. See above; works without. - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/#review74438 ----------------------------------------------------------- On Jan. 20, 2015, 9:55 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122114/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 9:55 p.m.) > > > Review request for Calligra and KDE Software on Mac OS X. > > > Repository: calligra > > > Description > ------- > > This patch adapts the build system to OS X with KDE4, Qt4 and other > dependencies installed through MacPorts. > > In order of appearance in the patch file: > - `-DQT_EXCEPTIONS`: this is for use with Qt built with its -no-exceptions > option, which MacPorts provides as an optional variant. > - Newer OS X variants only provide the clang compiler > - The default install location for MacPorts is `/opt/local`, but this can be > changed by the user. The header and library search paths required for > OpenJPEG, libpqxx and OpenVC are added using `//opt//local//` which is of > course equivalent to `/opt/local` but easier to search-and-replace with the > true install location in MacPorts' post-patch stage. > - the product set for OS X has been extended to all applications and features > that build and make sense. (Calligra Gemini builds, but does not function > properly.) > > A "Portfile" and accompanying patches that don't have the vocation to be > included "upstream" in calligra will be uploaded to MacPorts' trac system > soon. > > > Diffs > ----- > > CMakeLists.txt facb5f9 > cmake/modules/FindOpenJPEG.cmake 6bfd93c > cmake/modules/FindPqxx.cmake 3e24a0c > cmake/modules/FindVc.cmake bb9823f > cmake/productsets/osx.cmake 1fe8f1c > > Diff: https://git.reviewboard.kde.org/r/122114/diff/ > > > Testing > ------- > > On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6 installed through MacPorts. > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
