----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122354/#review75134 -----------------------------------------------------------
Ship it! Good work :-). I think it's time for you to follow https://techbase.kde.org/Contribute/Get_a_Contributor_Account and get commit/push access. You can use me or Dmitry as your reference, and then push your patch yourself :-) - Boudewijn Rempt On Feb. 1, 2015, 2:57 a.m., Aleksander Demko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122354/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2015, 2:57 a.m.) > > > Review request for Calligra. > > > Bugs: 330185 > http://bugs.kde.org/show_bug.cgi?id=330185 > > > Repository: calligra > > > Description > ------- > > Fixed bug Bug 330185 - Text Brush: Letters are upside down when > Rotation is set to Drawing Angle > > This bug was fixed by adding a new feature/parameter "angleOffset" > to the drawing angle option. Settings this new parameter to > 180 degrees will give the expected output in this user's case. > > The core issue is that when the drawing angle option is enabled, > an angle of 180 it sent when moving the cursor RIGHT. > KisTextBrush could some how test for this case and manually > subtract 180 to get "no rotation" when travelling right, but this > would be an ugly hack. > > > Diffs > ----- > > > krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.h > 34469d6 > > krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.cpp > 8351c3d > > Diff: https://git.reviewboard.kde.org/r/122354/diff/ > > > Testing > ------- > > > Thanks, > > Aleksander Demko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
