> On Jan. 15, 2015, 5:27 p.m., Jarosław Staniek wrote:
> > Your solution is a workaround - 1. we would need add the shortcut by hand
> > for every use of the table view, and 2. we wouldn't have global shortcut
> > available for configuration by users.
> >
> > Hmm, based on your other patch (for CTRL+F5) I tried this:
> >
> > --- kexi/widget/dataviewcommon/kexidataawareview.cpp
> > +++ kexi/widget/dataviewcommon/kexidataawareview.cpp
> > @@ -130,6 +130,7 @@ void KexiDataAwareView::initActions()
> > plugSharedAction("data_cancel_row_changes", this,
> > SLOT(cancelRowEdit()));
> >
> > d->actionClient->plugSharedAction(sharedAction("data_cancel_row_changes"));
> > //for proper shortcut
> >
> > d->actionClient->plugSharedAction(sharedAction("edit_insert_empty_row"));
> > //for proper shortcut
> > + addAction(sharedAction("edit_insert_empty_row"));
> >
> > setAvailable("data_sort_az", d->dataAwareObject->isSortingEnabled());
> > setAvailable("data_sort_za", d->dataAwareObject->isSortingEnabled());
> >
> >
> > ...and it works - both in table and query designer. However we wouldn't
> > need to explicitly call addAction() this way.
> >
> > Let's leave this unresolved for a while so I'll look how to improve the
> > overall API without workarounds. Looks like this would be ultimate fix,
> > shared actions come from Qt 3 era.
> >
> > Thanks.
Added todo: https://todo.kde.org/?controller=task&action=show&task_id=853
relates to https://git.reviewboard.kde.org/r/122051/ too
- Jarosław
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122053/#review74091
-----------------------------------------------------------
On Jan. 14, 2015, 2:19 p.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122053/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 2:19 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and
> Wojciech Kosowicz.
>
>
> Bugs: 338832 and 338833
> http://bugs.kde.org/show_bug.cgi?id=338832
> http://bugs.kde.org/show_bug.cgi?id=338833
>
>
> Repository: calligra
>
>
> Description
> -------
>
> https://bugs.kde.org/show_bug.cgi?id=338832
>
>
> Diffs
> -----
>
> kexi/main/KexiMainWindow.cpp f499951
>
> Diff: https://git.reviewboard.kde.org/r/122053/diff/
>
>
> Testing
> -------
>
> Shortcut works as expected in both Table and Query Design views.
> However, shortcut tip is not showed in the right-click menu.
>
>
> Thanks,
>
> Roman Shtemberko
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
