----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121620/ -----------------------------------------------------------
Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt. Bugs: https://bugs.kde.org/show_bug.cgi?id=341752 http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=341752 Repository: calligra Description ------- This patch fixes making the Krita resource bundles activate and deactivate by doing the following: 1. It adds two functions to KoResourceServer.h: removeFromBlacklist, which does what it says on the tin, and addResourceAndUnBlacklist which invokes both addResource and removeFromBlacklist. 2. It adds a setInstalled(bool) to resourcebundle.cpp, to be able to activate and deactivate that bool from outside(not sure if necessary) 3. Finally, it makes sure that dlg_bundle_manager can create existing bundles from the blacklisted ones, and either adds to server, removes from blacklist or gives feedback depending on the state of the bundle. Diffs ----- krita/plugins/extensions/resourcemanager/dlg_bundle_manager.cpp e8537d5 krita/plugins/extensions/resourcemanager/resourcebundle.h 9981c02 krita/plugins/extensions/resourcemanager/resourcebundle.cpp c73d9d1 libs/widgets/KoResourceServer.h 5d7c6c7 Diff: https://git.reviewboard.kde.org/r/121620/diff/ Testing ------- Tested it thoroughly. It works both on previously deactivated and newly deactivated bundles. Thanks, Wolthera van Hövell
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
