----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121123/#review70786 -----------------------------------------------------------
Ship it! Ship It! - Dan Leinir Turthra Jensen On Nov. 14, 2014, 6:48 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121123/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 6:48 p.m.) > > > Review request for Calligra, Camilla Boemann, Inge Wallin, Dan Leinir Turthra > Jensen, and Thorsten Zachmann. > > > Repository: calligra > > > Description > ------- > > Currently thumbnails for ODT files etc. are generated using the configured > view settings (incl. showing non-existing table borders, annotations, > textshape outlines, inlineobjects highlight, etc). IMHO pure thumbnails used > for previews outside of the editor app should just render pages like for > print, and only inside editor apps (e.g. when used for page overview widgets) > the thumbnails should be resembling the current display of the page in the > editor. > > Attached patch enables this, by adding a parameter to > `KWPage::thumbnail(...)` which allows to control how the rendering of > thumbnails is done. > > This fixes the preview thumbnails as generated for ODT files, both for > embedding into the file but also when generating previews in the filemanager > with the thumbnailer. > > Not sure about `CSThumbProviderWords::createThumbnails(...)` from cstester > though. Thorsten, which rendering should be done there? As for print, or as > for whatever is configured for the editor view? > > > Diffs > ----- > > extras/okularodtgenerator/OkularOdtGenerator.cpp d1b98a5 > words/part/KWDocument.cpp e287829 > words/part/KWPage.h 0821ccd > words/part/KWPage.cpp 5dc6a37 > > Diff: https://git.reviewboard.kde.org/r/121123/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
