----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120681/#review68800 -----------------------------------------------------------
Ship it! I think it would be best to initialize the size variables to 0 in the constructor, that way you can be sure your check will always work correctly. Apart from that, ship it. - Boudewijn Rempt On Oct. 21, 2014, 11:22 a.m., Scott Petrovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120681/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 11:22 a.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > A nice workflow enhancement when bouncing between drawing and erasing. > reference forum post: https://forum.kde.org/viewtopic.php?f=137&t=123333 > > > Diffs > ----- > > krita/ui/kis_paintop_box.h 5d40fbc > krita/ui/kis_paintop_box.cc 1fc6627 > > Diff: https://git.reviewboard.kde.org/r/120681/diff/ > > > Testing > ------- > > built Krita and made sure the feature worked. > > > Thanks, > > Scott Petrovic > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
