> On Aug. 14, 2014, 9:16 p.m., Friedrich W. H. Kossebau wrote: > > IMHO definitions should be only set for those source files for which they > > are interesting. > > Reason is that any definition becomes a dep for the .o file compiled, and > > if the dep changes, the source file has to be recompiled because the > > definition could influence te created .o file. So such global definitions > > are a pain for those of us who check different build configurations, > > because any change means a complete rebuild of everything. > > > > Currently I would rather like to see headers generated and explicitely > > included by those files which make use of the switch. > > > > So not in favour of this change, rather would like the opposite to happen, > > removal of the definition addition in the central CMakeLists.txt.
jstaniek -- will you pursue this patch, or should it be discarded following friedrich's recommendation? - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119168/#review64577 ----------------------------------------------------------- On Aug. 12, 2014, 10:03 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119168/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 10:03 p.m.) > > > Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. > Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, > Radosław Wicik, and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > cleanup: COMPILING_TESTS is inherited in subdirs so it needs to be set only > once > > > Diffs > ----- > > words/CMakeLists.txt a9b2b65b4bd35ed1258c2cc3ffb51afe626c13a7 > words/part/tests/CMakeLists.txt 1d66fb21c392b6e22165f0e91a2ce600aae60f60 > libs/flake/CMakeLists.txt 839b861c0a93b5cc2244b2565cda87f144e1429c > libs/kopageapp/CMakeLists.txt e3ae4dd7849fd49f99f06bc7cd1dcf90adb5fc61 > libs/koreport/CMakeLists.txt 26d299c54189f5b402348baa1821f7641a1afd74 > plan/CMakeLists.txt d9e24d868daf3fbbfe7c2253d34aef4ed50356ae > stage/part/CMakeLists.txt f79eea988d2066d90ebab0dab70f339b4ce6185d > > Diff: https://git.reviewboard.kde.org/r/119168/diff/ > > > Testing > ------- > > tested by building with tests > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
