----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120384/#review67511 -----------------------------------------------------------
Ship it! Looks like this doesn't conflict, at least not when I apply the patch directly to the mvc branch. - Boudewijn Rempt On Sept. 27, 2014, 9:41 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120384/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 9:41 a.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > This is the last batch of include cleanups I was giving some testing when > Boud hinted me that I am adding pain to his still on-going MVC branch work. > > Boud, does this patch conflict, so shall I wait with this until MVC is in? > Not urgent, I was just annoyed last week that changing a single file in the > libs resulted in massive recompile and thus wanted to cut down the > recompile-network where possible. But besides the two include insertions in > Karbon should not clash that much, so perhaps you are fine with getting this > in now. > > > Diffs > ----- > > libs/flake/commands/KoPathBreakAtPointCommand.cpp 97f1176 > libs/flake/commands/KoPathControlPointMoveCommand.h 083a5b6 > libs/flake/commands/KoPathPointInsertCommand.h 31eabdd > libs/flake/commands/KoPathPointInsertCommand.cpp e66a6d5 > libs/flake/commands/KoPathPointMoveCommand.h af8bfcf > libs/flake/commands/KoPathPointRemoveCommand.h 586eede > libs/flake/commands/KoPathPointRemoveCommand.cpp 24ee801 > libs/flake/commands/KoPathSegmentBreakCommand.h b4cae62 > libs/flake/commands/KoPathSegmentBreakCommand.cpp 78a5070 > libs/flake/commands/KoPathShapeMarkerCommand.h 54b81a0 > libs/flake/commands/KoPathShapeMarkerCommand.cpp 69f056a > libs/flake/commands/KoShapeAlignCommand.h c14ff30 > libs/flake/commands/KoShapeBackgroundCommand.h 1a24ad2 > libs/flake/commands/KoShapeDistributeCommand.h 0bb0bf0 > libs/flake/commands/KoShapeDistributeCommand.cpp 0bae876 > libs/flake/commands/KoShapeGroupCommand_p.h 16b0311 > libs/flake/commands/KoShapeMoveCommand.h 59c3e6b > libs/flake/commands/KoShapeMoveCommand.cpp 5983690 > libs/flake/commands/KoShapeReorderCommand.h 60540fd > libs/flake/commands/KoShapeSizeCommand.h 0a604d3 > libs/flake/commands/KoShapeSizeCommand.cpp 87d7a59 > libs/flake/commands/KoShapeTransparencyCommand.h d08c4da > libs/flake/commands/KoShapeTransparencyCommand.cpp de18578 > libs/flake/commands/KoShapeUnclipCommand.cpp 5100f15 > libs/flake/commands/KoShapeUngroupCommand.h c09a2e4 > libs/flake/commands/KoSubpathRemoveCommand.h 8c1d0f6 > libs/flake/commands/KoSubpathRemoveCommand.cpp 3671409 > libs/flake/svg/SvgClipPathHelper.h ea8b544 > libs/flake/svg/SvgCssHelper.cpp 2745b3c > libs/flake/svg/SvgFilterHelper.h efe4d2f > libs/flake/svg/SvgGradientHelper.h 1e1aaba > libs/flake/svg/SvgGradientHelper.cpp c2a6090 > libs/flake/svg/SvgLoadingContext.cpp 14bef1b > libs/flake/svg/SvgParser.h 1a7d27b > libs/flake/svg/SvgParser.cpp cb760ed > libs/flake/svg/SvgShape.h 949b8cd > libs/flake/svg/SvgShape.cpp 4acdde5 > libs/flake/svg/SvgStyleWriter.h f83b45b > libs/flake/svg/SvgUtil.h c6d786c > libs/flake/svg/SvgWriter.h bd08b37 > libs/flake/svg/SvgWriter.cpp 200bc3c > plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp e4ffb94 > plugins/defaultTools/defaulttool/ShapeResizeStrategy.cpp 516cc57 > plugins/defaultTools/defaulttool/ShapeShearStrategy.cpp 5038450 > karbon/ui/KarbonDocument.cpp 7e28a4c > karbon/ui/KarbonView.cpp dd097fc > libs/flake/commands/KoParameterToPathCommand.h 2784675 > libs/flake/commands/KoParameterToPathCommand.cpp 52d9b51 > libs/flake/commands/KoPathBreakAtPointCommand.h 8bcd714 > > Diff: https://git.reviewboard.kde.org/r/120384/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
