----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120291/ -----------------------------------------------------------
(Updated Sept. 20, 2014, 12:18 p.m.) Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn Rempt. Changes ------- Finished this! Repository: calligra Description ------- This patch tries to clean up the big list of colour selectors left by the last patch. It contains a set of radio buttons that set the model type, and the list of widgets underneath is updated to only present colour selectors in that type. It also adds some explaination of each type. Beneath that, there's the Luma settings, with explaination. These values are saved to the kritarc file under advanced colour selector. Diffs (updated) ----- krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_wheel.cpp df15586 krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_wheel.h 5258aea krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_simple.h 6d1c773 krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_simple.cpp 38d66c5 krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_combo_box.h 486434a krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_combo_box.cpp c6658a1 krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.h d4240fe krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.cpp bbed40e krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.h 77e50e1 krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp 7dcf36c krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui f83e768 krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.h f223392 krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.cpp 5895488 krita/plugins/extensions/dockers/colorslider/kis_hsv_slider.h ae419e8 krita/plugins/extensions/dockers/colorslider/kis_hsv_slider.cpp 4c06d14 Diff: https://git.reviewboard.kde.org/r/120291/diff/ Testing (updated) ------- It works but due to the widget list being reorganised, you need to select a selector first, save the preferences, to end up with the proper list. I am not sure why. Todo: * ~~Make the luma-coefficients actually have effect.~~[done] * ~~Have the information on the models be aligned properly.~~[done] * ~~Make invisible widgets unselectable~~[done] * ~~Maybe remove triangle from all non-hsv types: On one hand it is a true wildcard selector; it fits in all types, on the other hand due QGridLayout being pretty inflexible in regards to auto-filling it now looks ugly.~~[done, different solution] * ~~Add missing hsi and hsy selectors.~~[done] * ~~Organise the widgets more nicely.~~[done] Thanks, Wolthera van Hövell
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
