----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120114/#review66215 -----------------------------------------------------------
Ship it! Good find and great advice! - Jarosław Staniek On Sept. 9, 2014, 3:46 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120114/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 3:46 p.m.) > > > Review request for Calligra and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > My compiler complained about the result of > designer.getSelectionPressX() + 15; > being unused. I guess you forgot that snippet accidently, and would propose > to remove it. > > Golden rule: listen to your compiler, unless you are sure it is wrong, and > then act on it :) > Ideally there should be no warnings in the output. > > And while removing that line, I also would propose to call > designer.countSelectionHeight() and the other only all. > This can be done by using qMax, to ensure that the value is at least 15. > > > Diffs > ----- > > libs/koreport/items/check/KoReportDesignerItemCheck.cpp e6ff156 > > Diff: https://git.reviewboard.kde.org/r/120114/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
