----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120112/#review66115 -----------------------------------------------------------
Thanks for investigating the issue. The crash was probably introduced by me and Wojtek yesterday. m_detail should not be 0 outside of init() so it doesn't need to be checked in other methods -- we'll investigate the best way to fix, probably in init() (?). - Jarosław Staniek On Sept. 9, 2014, 12:12 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120112/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:12 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, and Wojciech > Kosowicz. > > > Repository: calligra > > > Description > ------- > > Latest Kexi master crashes for me when going to Design mode with reports. > > Reason is that existance of m_detail is not properly checked for everywhere. > Guess only some recent changes outside of KoReportDesigner are triggering > these crashes now, as this code is quite old. > > No idea if that is a problem in 2.8, at least I have not seen this problem in > master ever before. Still by the code it might make sense to backport it. > Needs somebody who runs 2.8, though, I don't have that. > > > Diffs > ----- > > libs/koreport/wrtembed/KoReportDesigner.cpp 8e107bf > > Diff: https://git.reviewboard.kde.org/r/120112/diff/ > > > Testing > ------- > > No longer crashes with my test files. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
