> On Aug. 30, 2014, 9:41 a.m., Jarosław Staniek wrote: > > libs/koreport/items/check/KoReportDesignerItemCheck.cpp, line 58 > > <https://git.reviewboard.kde.org/r/119527/diff/2/?file=303641#file303641line58> > > > > Could const KoReportDesigner & be enough?
how should look method declaration in your opinion? :) QSizeF KoReportDesignerItemRectBase::minimumSize() const = 0; that's what you suggested in the previous review I had to add KoReportDesigner pointer as it was needed - Wojciech ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119527/#review65537 ----------------------------------------------------------- On Aug. 10, 2014, 8:28 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119527/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 8:28 p.m.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Bugs: 334967 > http://bugs.kde.org/show_bug.cgi?id=334967 > > > Repository: calligra > > > Description > ------- > > If the specified dimensions are improper or too small elements get their > defaults size > > > Diffs > ----- > > libs/koreport/items/check/KoReportDesignerItemCheck.h 2ef6759 > libs/koreport/items/check/KoReportDesignerItemCheck.cpp 5bebc6c > libs/koreport/items/field/KoReportDesignerItemField.h fef7346 > libs/koreport/items/field/KoReportDesignerItemField.cpp 0dc9325 > libs/koreport/items/image/KoReportDesignerItemImage.h c7f3484 > libs/koreport/items/image/KoReportDesignerItemImage.cpp 87e46a1 > libs/koreport/items/label/KoReportDesignerItemLabel.h b2aa78f > libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a80 > libs/koreport/items/text/KoReportDesignerItemText.h 19ba551 > libs/koreport/items/text/KoReportDesignerItemText.cpp 51e12d3 > libs/koreport/wrtembed/KoReportDesigner.h adc712a > libs/koreport/wrtembed/KoReportDesigner.cpp 63152a7 > libs/koreport/wrtembed/KoReportDesignerItemBase.h de94858 > libs/koreport/wrtembed/KoReportDesignerItemBase.cpp 231771e > libs/koreport/wrtembed/KoReportDesignerItemLine.h 894cec9 > libs/koreport/wrtembed/KoReportDesignerItemLine.cpp 1b0474d > libs/koreport/wrtembed/KoReportDesignerItemRectBase.h b53a58e > libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 53c3727 > libs/koreport/wrtembed/reportsceneview.h cc3ab9f > libs/koreport/wrtembed/reportsceneview.cpp 2b679a4 > plugins/reporting/barcode/KoReportDesignerItemBarcode.h 384863b > plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp b4fb621 > plugins/reporting/maps/KoReportDesignerItemMaps.h 56fbb6b > plugins/reporting/maps/KoReportDesignerItemMaps.cpp f624db3 > plugins/reporting/web/KoReportDesignerItemWeb.h d2d7ce0 > plugins/reporting/web/KoReportDesignerItemWeb.cpp 63e1cc9 > > Diff: https://git.reviewboard.kde.org/r/119527/diff/ > > > Testing > ------- > > When adding any element in kexi report it will the same size as specified by > the user at the moment of adding > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
