----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119136/ -----------------------------------------------------------
(Updated July 29, 2014, 1:52 a.m.) Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz. Changes ------- Port of Kexi plugins to the new API of KoServiceLocator and Kexi's plugin loader (libs/db/pluginloader.* files were commited by Boud already) * Use org.kexi-project.* class names (e.g. org.kexi-project.importexport.csv) instead of simple part names * Have the same plugin management for object parts and internal parts * Only require class in parts, don't require object type name * Normalize X-KDE-ServiceTypes: use Kexi/ prefix * Drop code that calls kbuildsycoca4 on error: we don't depend on KSyCoCa * Fix some dirs of desktop files: everything now goes to calligra/ * Do not specify X-Kexi-TypeName, X-Kexi-TypeMime, X-Kexi-GroupIcon and X-Kexi-ItemIcon when not needed in parts' desktop files * Reduced #includes Tested plugins affected. They load and work properly. Repository: calligra Description ------- Fix issue with resolving version of plugins (at least) on Linux Use C function instead of int member. By the way simplify code using wrapper class. Diffs (updated) ----- libs/koreport/common/KoReportPluginInterface.h 32629af libs/koreport/common/KoReportPluginManager.cpp 246027c plugins/kexi/spreadsheet/spreadsheetmigrate.cpp 03b728c kexi/plugins/queries/CMakeLists.txt 31355a9 kexi/plugins/queries/kexiquerydesignerguieditor.cpp 3b31b91 kexi/plugins/queries/kexiquerypart.cpp ded8537 kexi/plugins/relations/CMakeLists.txt e5a888a kexi/plugins/relations/kexirelationhandler.desktop 5a7765e kexi/plugins/relations/kexirelationpartimpl.cpp 901038a kexi/plugins/reports/CMakeLists.txt 51dd75c kexi/plugins/reports/kexireports.cpp 67b4189 kexi/plugins/scripting/kexiscripting/CMakeLists.txt f3f07d9 kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp 158b5ac kexi/plugins/tables/CMakeLists.txt 4aeb380 kexi/plugins/tables/kexitablepart.cpp 36c5922 kexi/tests/altertable/altertable.cpp 4a73af8 kexi/widget/kexidbconnectionwidget.cpp 8555702 kexi/widget/navigator/KexiProjectModel.cpp d5ec550 kexi/widget/navigator/KexiProjectNavigator.cpp 7e665ac libs/db/CMakeLists.txt 419a06a libs/db/driver.h ed2469f libs/db/driver_p.h 62a23db libs/db/drivermanager.cpp ddca64e libs/db/drivers/sqlite/sqlitedriver.cpp f28ec7f libs/koreport/CMakeLists.txt 26d299c kexi/plugins/forms/widgets/webbrowser/kformdesigner_webbrowser.desktop 960616c kexi/plugins/importexport/csv/CMakeLists.txt 9324ef1 kexi/plugins/importexport/csv/kexicsv_importexporthandler.desktop 909e8fc kexi/plugins/importexport/csv/kexicsv_importexportpart.cpp 7a6e8a8 kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 426368a kexi/plugins/migration/CMakeLists.txt f123d10 kexi/plugins/migration/keximigrationhandler.desktop 96364d1 kexi/plugins/migration/keximigrationpart.cpp 21b0d88 kexi/plugins/forms/widgets/mapbrowser/CMakeLists.txt 21ee0b4 kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp 5d9ecb9 kexi/plugins/forms/widgets/mapbrowser/kformdesigner_mapbrowser.desktop 9e076b5 kexi/plugins/forms/widgets/webbrowser/CMakeLists.txt eb5c633 kexi/plugins/forms/widgets/webbrowser/WebBrowserFactory.cpp fa768cc kexi/plugins/forms/kformdesigner_kexidbfactory.desktop 77c1190 kexi/migration/sybase/sybasemigrate.cpp 4967726 kexi/migration/txt/txtmigrate.h 8f87a8a kexi/migration/txt/txtmigrate.cpp 1cf3805 kexi/migration/xbase/xbasemigrate.h 18ec111 kexi/migration/xbase/xbasemigrate.cpp 403ea86 kexi/plugins/autoforms/CMakeLists.txt a4e9f84 kexi/plugins/autoforms/KexiAutoForms.cpp 874e081 kexi/plugins/forms/CMakeLists.txt 0503396 kexi/plugins/forms/kexidbfactory.cpp b320afd kexi/plugins/forms/kexiforms.cpp 24be71e kexi/main/startup/KexiRecentProjectsModel.cpp 303b5eb kexi/main/startup/KexiStartup.h 0c7dd13 kexi/main/startup/KexiStartup.cpp 6daf5b1 kexi/migration/importtablewizard.cpp 48fa2b0 kexi/migration/keximigrate.h 606d58b kexi/migration/keximigrate_p.h 6977232 kexi/migration/mdb/src/keximdb/mdbmigrate.h 320c3e0 kexi/migration/mdb/src/keximdb/mdbmigrate.cpp af8e432 kexi/migration/migratemanager.cpp 0a52a73 kexi/migration/mysql/mysqlmigrate.h 0a0bd2b kexi/migration/mysql/mysqlmigrate.cpp d511d15 kexi/migration/pqxx/pqxxmigrate.h 1870cd2 kexi/migration/pqxx/pqxxmigrate.cpp ecd9873 kexi/migration/sybase/sybasemigrate.h 5bdbb87 kexi/kexidb/drivers/oracle/oracledriver.cpp 64d1efc kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 2f1ea2b kexi/kexidb/drivers/sybase/sybasedriver.cpp e2c9d52 kexi/kexidb/drivers/xbase/xbasedriver.cpp f3f5f49 kexi/main/KexiMainWindow.cpp 89e9386 kexi/main/KexiUserFeedbackAgent.cpp b07407e kexi/formeditor/widgetfactory.desktop 1fb3724 kexi/formeditor/widgetfactory.h 2a8fb7f kexi/formeditor/widgetlibrary.cpp 883d678 kexi/kexidb/drivers/mysql/mysqldriver.cpp b243685 kexi/kexidb/drivers/odbc/kodbcdriver.cpp 4be9645 kexi/formeditor/factories/containerfactory.cpp 20ade31 kexi/formeditor/factories/kformdesigner_containers.desktop f89cb40 kexi/formeditor/factories/kformdesigner_stdwidgets.desktop 746428f kexi/formeditor/factories/stdwidgetfactory.cpp 45347ae kexi/formeditor/kexiactionselectiondialog.cpp c31c70c kexi/formeditor/kexiformeventhandler.cpp 29e5bfb kexi/core/kexipartmanager.cpp 0aae8df kexi/core/kexiprojectset.cpp 4008152 kexi/core/kexistaticpart.cpp cf276cd kexi/data/CMakeLists.txt 53569f2 kexi/data/kexihandler.desktop c0bfef1 kexi/formeditor/factories/CMakeLists.txt 5db434a kexi/core/kexipartbase.h PRE-CREATION kexi/core/kexipartbase.cpp PRE-CREATION kexi/core/kexipartinfo.h 2742818 kexi/core/kexipartinfo.cpp f9f1fa7 kexi/core/kexipartmanager.h caa7e49 kexi/core/CMakeLists.txt 6ba58f1 kexi/core/KexiMainWindowIface.h 8a26de1 kexi/core/kexi.h 92c83b8 kexi/core/kexi.cpp 4e1d5fa kexi/core/kexihandler.desktop PRE-CREATION kexi/core/kexiinternalpart.h 7757b37 kexi/core/kexiinternalpart.cpp 9e9100c kexi/core/kexipart.h 172fd0e kexi/core/kexipart.cpp e1759ce Diff: https://git.reviewboard.kde.org/r/119136/diff/ Testing ------- tested every type of plugin affected Thanks, Jarosław Staniek
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
