----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118106/#review57984 -----------------------------------------------------------
This review has been submitted with commit 447eed08ca1f9714545a0ce077f9d9565b1d1d48 by Friedrich W. H. Kossebau to branch master. - Commit Hook On May 12, 2014, 8:02 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118106/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 8:02 p.m.) > > > Review request for Calligra, Yue Liu, Boudewijn Rempt, and Jos van den Oever. > > > Repository: calligra > > > Description > ------- > > "find_program(RNG2CCP_EXECUTABLE rng2cpp [...])", as used to find the path to > the rng2cpp executable on Windows, has the disadvantage that it will only > work once rng2cpp has been build the first time. > > Instead I propose to use the built-in resolution of the created executable > and dependency creation with add_custom_command, see > http://www.cmake.org/cmake/help/v2.8.0/cmake.html#command:add_custom_command: > " > [...] > If COMMAND specifies an executable target (created by ADD_EXECUTABLE) it will > automatically be replaced by the location of the executable created at build > time. Additionally a target-level dependency will be added so that the > executable target will be built before any target using this custom command. > However this does NOT add a file-level dependency that would cause the custom > command to re-run whenever the executable is recompiled. > [...] > " > Keeping rng2cpp and ${RNGFILE} as DEPENDS ensure that there is file-level > dependency also to the executable. > > Works for me on Linux. Does it also work on Windows and OSX? > > > Diffs > ----- > > libs/odf/writeodf/CMakeLists.txt 9a99d48 > > Diff: https://git.reviewboard.kde.org/r/118106/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
